Pivotal ID # 181937926: Avoid restarting ITests containers #560
Conversation
There was a problem hiding this comment.
These changes look great and something our itests were needing for a long time. If I understood them correctly, what we're doing now is starting the containers once and running all the tests there. We're now also sharing a single instance of the temporary folder through the tests.
I only have one suggestion, should we have a dictionary with the accessions used for each test? Maybe putting them all in constants somewhere so we avoid collisions in the future.
Other than that, I only left some minor comments but everything looks great.
| @@ -26,6 +26,10 @@ class SecurityTestService( | |||
| return user | |||
| } | |||
|
|
|||
| fun ensureRegisterUser(testUser: TestUser) { | |||
There was a problem hiding this comment.
I'd suggest ensureUserRegistration
| import ac.uk.ebi.biostd.client.integration.web.SecurityWebClient | ||
| import ac.uk.ebi.biostd.itest.entities.TestUser | ||
|
|
||
| fun getWebClient(serverPort: Int, user: TestUser): BioWebClient { |
There was a problem hiding this comment.
one-liner
fun getWebClient(serverPort: Int, user: TestUser): BioWebClient =
SecurityWebClient
.create("http://localhost:$serverPort")
.getAuthenticatedClient(user.email, user.password)
| @@ -0,0 +1 @@ | |||
| ac.uk.ebi.biostd.itest.itest.ITestListener | |||
Make sense yes, I will create several tickets to enhace itest which need a lot of re organizations. |
jhoanmanuelms
deleted the
chore/pivotal-181937926-avoid-restarting-itests-containers
branch
https://www.pivotaltracker.com/story/show/181937926