Pivotal ID # 181807913: Add MD5 To Pagetab #558
Conversation
Add calculated MD5 to pagetab files
| } | ||
|
|
||
| private fun ExtFile.toAttributes() = |
There was a problem hiding this comment.
attributes.map { it.toAttribute() } + Attribute(MD5.value, md5)
| } | ||
|
|
||
| private fun ExtFile.toAttributes() = |
There was a problem hiding this comment.
I think name toAttributes and function is misleading (is an extension function of file) as we are not transforming a file into attributes, we are transforming file attributes into ext attributes. To make more clear imagine you have a class human that have a born_country attribute and one declarate an extension Human.getPopulation which obtain the population of the country.
Even function implementation can be correct, is not correct to model a human with shuch operation.
|
About your question, yes, we already have logic that filters it out at deserialization but I added an integration test just to be sure |
- Improve method naming - Add MD5 attribute to testing - Fix Ktlint error
https://www.pivotaltracker.com/story/show/181807913
Add calculated MD5 to pagetab files