Pivotal ID # 186941052: Check Ftp Connections Before Borrow (#802)

https://www.pivotaltracker.com/story/show/186941052 Enable test on borrow --------- Co-authored-by: Jhoan Munoz <jhoanmanuelms@gmail.com>
EBIBioStudies · Jan 30, 2024 · b5aaca4 · b5aaca4
1 parent 26c8a99
commit b5aaca4
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/client/ftp-webclient/src/main/kotlin/ebi/ac/uk/ftp/FTPClientPool.kt b/client/ftp-webclient/src/main/kotlin/ebi/ac/uk/ftp/FTPClientPool.kt
@@ -71,8 +71,8 @@ internal class FTPClientPool(
             val ftpClient = p.`object`
             return try {
                 ftpClient.sendNoOp()
-            } catch (e: Exception) {
-                logger.error(e) { "Error checking ftp connection" }
+            } catch (exception: Exception) {
+                logger.error { "Error checking ftp connection: ${ exception.localizedMessage }" }
                 false
             }
         }
@@ -91,6 +91,7 @@ internal class FTPClientPool(
             val factory = FTPClientFactory(ftpUser, ftpPassword, ftpUrl, ftpPort, ftpRootPath)
             var connections = GenericObjectPool(factory)
             connections.minIdle = MIN_CONNECTION
+            connections.testOnBorrow = true
             return connections
         }
     }