-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2.2.2 prep #93
Merged
Merged
V2.2.2 prep #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tgurbich
commented
Apr 8, 2024
•
edited
Loading
edited
- Modified the annotate_gff.py script (removed dashes when IPR accession is unknown, fixed COG handling, added GO-terms, added e-value filter for eggNOG and InterProScan results)
- Fixed a bug in the readme generation script to correctly detect Archaea presence
- Enabled pre-determined MGYG accessions
- Added a script to post-process GTDB results if there are unknown genomes
- Added fallback to NCBI when getting sample location metadata if ENA returns an error (non GCA genomes)
- Added a switch to FastTree from IQTree if number of species reps is >=2k
- Added accounting for unclassified genomes in website JSONs
- Small bug fixes
KateSakharova
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good. I left one comment
…cript Fix/modify deduplicate script
Conditional usage of IQTree or FastTree
This has to be tested.
Fixed shellcheck lint problems. Most problems where missing quotes (https://www.shellcheck.net/wiki/SC2086)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.