Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed path to modules #45

Merged
merged 5 commits into from
Jun 9, 2023
Merged

Fixed path to modules #45

merged 5 commits into from
Jun 9, 2023

Conversation

tgurbich
Copy link
Contributor

@tgurbich tgurbich commented Jun 8, 2023

We moved get_ENA_metadata.py and utils.py to the bin folder which broke fetch_ena.py and fetch_ncbi.py. Added relative paths to both scripts to fetch the modules.

@tgurbich tgurbich requested a review from mberacochea June 8, 2023 12:17
@mberacochea
Copy link
Member

Wouldn't be easier to move those scripts to the bin folder?

@tgurbich
Copy link
Contributor Author

tgurbich commented Jun 9, 2023

Moved scripts to bin.

@mberacochea
Copy link
Member

Moved scripts to bin.

Perfect. I've added a copy of the retry library, I just copied the library directly. The library is old and deprecated, so we should migrate to a different one.
For now, and as the library only needs the python standard library, I've copied the source code into the bin folder.

@mberacochea mberacochea merged commit 9717316 into dev Jun 9, 2023
@mberacochea mberacochea deleted the bug-fix/fetch-script branch June 23, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants