Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add qs50 filtering #36

Merged
merged 8 commits into from
Apr 25, 2023
Merged

Feature/add qs50 filtering #36

merged 8 commits into from
Apr 25, 2023

Conversation

KateSakharova
Copy link
Collaborator

  • Added QS50 filter before rename step and test
  • Moved cpus and memory to config files
  • Added local nf.config for docker

@KateSakharova KateSakharova self-assigned this Apr 3, 2023
@KateSakharova KateSakharova changed the base branch from master to dev April 3, 2023 14:14
@@ -117,5 +119,19 @@ profiles {
executor {
name = "local"
}
includeConfig 'config/local.config'
}
local_docker {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has some repeated bits with local and local_docker, I think we can just have local, docker, singularity as separate entries and then use them as needed -profile local,docker or -profile local,singularity

something like this:

docker {
    enabled = true
    fixOwnership = true
    autoMounts = true
}

singularity {
    enabled = true
    autoMounts = true
    remove = false
}

local {
    params.outdir = "result"
    executor {
        name = "local"
        cpus = 2
    }
    includeConfig 'config/local.config'
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to make this change in a different branch

Copy link
Member

@mberacochea mberacochea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me :)

@mberacochea mberacochea merged commit e116c30 into dev Apr 25, 2023
@mberacochea mberacochea deleted the feature/add_qs50_filtering branch April 26, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants