-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add qs50 filtering #36
Conversation
KateSakharova
commented
Apr 3, 2023
- Added QS50 filter before rename step and test
- Moved cpus and memory to config files
- Added local nf.config for docker
@@ -117,5 +119,19 @@ profiles { | |||
executor { | |||
name = "local" | |||
} | |||
includeConfig 'config/local.config' | |||
} | |||
local_docker { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has some repeated bits with local
and local_docker
, I think we can just have local
, docker
, singularity
as separate entries and then use them as needed -profile local,docker
or -profile local,singularity
something like this:
docker {
enabled = true
fixOwnership = true
autoMounts = true
}
singularity {
enabled = true
autoMounts = true
remove = false
}
local {
params.outdir = "result"
executor {
name = "local"
cpus = 2
}
includeConfig 'config/local.config'
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to make this change in a different branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me :)