Provide js and font assets via npm #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…menu update scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced js and font assets with latest available versions provided by npm and added npm package files. This should let us enable dependabot and get rid of some security warnings. Note that this PR keeps us on bootstrap@3 which still has an XSS warning. bootstrap@5 has breaking changes so I think the upgrade should be investigated separately.
This also added asset and menu update scripts. The menu update script allows the top menu to be defined in a single html file which will be inserted into each page. The menu definition file could be expanded to handle more of the shared code if that would be useful for applying updates in the future. @maherou