EAMxx: minor cleanup of diagnostics classes #7053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Diags don't have the power to determine whether the input fields will be allocated with packing allowed. Hence, just use Real for scalar type for now
bartgol
added
BFB
bartgol
commented
Feb 22, 2025
| @@ -1314,16 +1314,9 @@ void AtmosphereOutput::set_diagnostics() | |||
| { | |||
| const auto sim_field_mgr = get_field_manager("sim"); | |||
| // Create all diagnostics | |||
| for (auto& fname : m_fields_names) { | |||
There was a problem hiding this comment.
This mod is the main reason for the changes above: in another PR, where I'm reworking the scorpio_output impl, the fact that we need to be aware that entries in m_fields_names may change when diags are created is a bit annoying. It is also confusing...
bartgol
commented
Feb 22, 2025
bartgol
force-pushed
the
bartgol/eamxx/diagnostics-minor-cleanup
branch
from
6f6d271 to
0af792a
Compare
mahf708
approved these changes
Feb 22, 2025
|
Pls explain somewhere the part about packs or i can ask you about it later |
|
The non-MMF2 fails for v1 are unexpected, and the cprnc output is odd. I am running manually to see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name()method of the class[BFB]
Regarding packs: when a diagnostic is created, the fields in the FieldManager have already been created/allocated. As such, it is incorrect for diagnostics to request a pack size for their input fields, as the fields allocation is done already. The diagnostics could in theory check if the input fields have a pack size large enough or not, but that makes them more complicated.
In practice, it may be possible to just "assume" inputs are available with a Pack data type, since typical EAMxx process do require packed fields. However, I find this hidden assumption dangerous, so I'd rather avoid that. I'd rather settle for diagnostics that are working without packs (for now), and maybe revisit this if/when we get to reorganize how we provide diagnostics, maybe allowing diag fields to be in the FM (for simplicity). If anyone is interested in the issue, ping me, and we can chat offline.