Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/611/demo all validation #612

Closed
wants to merge 10 commits into from
Closed

Feature/611/demo all validation #612

wants to merge 10 commits into from

Conversation

tobigremmer-dt
Copy link
Contributor

Resolves #611

@tobigremmer-dt tobigremmer-dt mentioned this pull request Mar 28, 2024
Open
@tobigremmer-dt tobigremmer-dt marked this pull request as ready for review March 28, 2024 15:31
@tobigremmer-dt tobigremmer-dt requested a review from a team as a code owner March 28, 2024 15:31
@tobigremmer-dt
Copy link
Contributor Author

tobigremmer-dt commented Apr 2, 2024 •
edited
Loading

TBD:

  • Docs for ensure-notebook.yml and delete-notebook.yml

drqc
drqc approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@drqc drqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Just one observation for the are_nightly_auto_runs_enabled part, can you add more docs maybe on the next PR. So it explains where to check the validation and if you are using an email to alert the status maybe provide a email var

@tobigremmer-dt tobigremmer-dt marked this pull request as draft April 17, 2024 13:55
@tobigremmer-dt
Copy link
Contributor Author

As discussed with team, email notifications shall be implemented as a first step.

@tobigremmer-dt
Copy link
Contributor Author

Added comment to #611 . Closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drqc drqc drqc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] demo-all nightly validation
2 participants
@tobigremmer-dt @drqc