Node Tooltip Delay Timer fix #863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| twoSecondsWaitTimer = new DispatcherTimer(); | ||
| twoSecondsWaitTimer.Interval = TimeSpan.FromSeconds(2); // two seconds wait | ||
| delayTimer = new DispatcherTimer(); | ||
| delayTimer.Interval = TimeSpan.FromSeconds(Configurations.NodeToolTipFadeInDelayInSeconds); |
There was a problem hiding this comment.
Ben's golden rules:
- Before creating a data member, check if it is already created (especially on recurring method like this).
- Before accessing a data member, check to see if it is null.
Luke's golden rule:
- If ReferencePointGridXYZ - Want Z array #2 in Ben's golden rule causes too many null checks, we might as well instantiate the data member as part of the owner's construction.
added 2 commits
November 29, 2013 15:29
2. Made timer stop after one tick
Benglin
added a commit
that referenced
this pull request
Nov 30, 2013
…coButterUI This fixes a rather important and easy-to-reproduce crash when mouse moves away from out-ports, so I'm accepting this pull request in the interest of having it tested earlier.
sharadkjaiswal
pushed a commit
to sharadkjaiswal/Dynamo
that referenced
this pull request
Mar 31, 2014
…rFix_ChocoButterUI This fixes a rather important and easy-to-reproduce crash when mouse moves away from out-ports, so I'm accepting this pull request in the interest of having it tested earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important fix
This is fixing a crash upon null pointer exception (Added null checks to fix this)
Changes