Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing test that checks for runtime loaded assembly when running in serial #15637

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

aparajit-pratap
Copy link
Contributor

Purpose

attempt fixing test for linux

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section

Reviewers

(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)

(FILL ME IN, optional) Any additional notes to reviewers or testers.

FYIs

(FILL ME IN, Optional) Names of anyone else you wish to be notified of

@mjkkirschner
Copy link
Member

also curious, where are the tests actually running on linux?

Copy link

github-actions bot commented Nov 12, 2024

UI Smoke Tests

Test: success. 11 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests

@aparajit-pratap
Copy link
Contributor Author

also curious, where are the tests actually running on linux?

They are running on DynamoWinBuild here.

@mjkkirschner
Copy link
Member

I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds?

@aparajit-pratap
Copy link
Contributor Author

I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds?

Is there anything special we do for FFITarget?

@mjkkirschner
Copy link
Member

mjkkirschner commented Nov 14, 2024

I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds?

Is there anything special we do for FFITarget?

I think we actually inadvertently distribute FFITarget today - but for other test binaries we exclude them for the dynamocore builds on master-15 here:

<Exec Command="robocopy $(DYNAMO_BASE_PATH)\bin\AnyCPU\$(Configuration) $(DYNAMO_HARVEST_PATH) -XF %2aTest%2a.dll %2a.pdb TestResult.xml %2a.deps.json -e -XD int -XD Revit_2016 -XD Revit_2017 -XD Revit_2018 -XD samples -XD 0.8" IgnoreExitCode="true" />

For the nugets I think we exclude in the nuspecs.

@aparajit-pratap
Copy link
Contributor Author

@mjkkirschner I'll make a separate PR to exclude test related assemblies from the nuspec definition for the serviceruntimecore package.

@aparajit-pratap aparajit-pratap changed the title attempt fixing test for linux Fix failing test that checks for runtime loaded assembly when running in serial Nov 14, 2024
@QilongTang QilongTang added this to the 3.5 milestone Nov 14, 2024
@aparajit-pratap aparajit-pratap merged commit 421e48e into DynamoDS:master Nov 14, 2024
23 of 24 checks passed
@aparajit-pratap aparajit-pratap deleted the fixTest4Linux branch November 14, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants