-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing test that checks for runtime loaded assembly when running in serial #15637
Fix failing test that checks for runtime loaded assembly when running in serial #15637
Conversation
also curious, where are the tests actually running on linux? |
UI Smoke TestsTest: success. 11 passed, 0 failed. |
They are running on |
I guess we will want to make sure this new assembly is not delivered as part of core in our various nugets and builds? |
Is there anything special we do for FFITarget? |
I think we actually inadvertently distribute FFITarget today - but for other test binaries we exclude them for the dynamocore builds on master-15 here:
For the nugets I think we exclude in the nuspecs. |
…path for dynamocoreruntime package
@mjkkirschner I'll make a separate PR to exclude test related assemblies from the nuspec definition for the serviceruntimecore package. |
Purpose
attempt fixing test for linux
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
(FILL ME IN) Brief description of the fix / enhancement. Use N/A to indicate that the changes in this pull request do not apply to Release Notes. Mandatory section
Reviewers
(FILL ME IN) Reviewer 1 (If possible, assign the Reviewer for the PR)
(FILL ME IN, optional) Any additional notes to reviewers or testers.
FYIs
(FILL ME IN, Optional) Names of anyone else you wish to be notified of