Fix ContainsEmptyListOrNullTest test #15190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinzart90
commented
May 3, 2024
|
|
||
| var hwm = this.ViewModel.CurrentSpace; | ||
| return (nullNodesImageCount == nullNodesCount) && (emptyListNodesImageCount == emptyListNodesCount); | ||
| }); |
There was a problem hiding this comment.
DoEventsLoop will fail after 20 seconds if the function argument does not return true.
UI Smoke TestsTest: success. 2 passed, 0 failed. |
|
Test passed (like many times before). |
|
Thank you @pinzart90 , really appreciate it! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems ContainsEmptyListOrNullTest still finishes before the UI has a chance to fully update
I this PR I added more dispatcher queue processing time.