-
Notifications
You must be signed in to change notification settings - Fork 638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dyn 6821 home page links fix #15098
Dyn 6821 home page links fix #15098
Conversation
This reverts commit 765542d.
DynamoDS#15092) This reverts commit 765542d.
- fixes homepage links - this was broken during the drag&drop implementation
Sorry @dnenov I think our team rebased master branch so your |
Thanks for the heads up @QilongTang ! Reverted the changes in both my affected PRs |
hi @dnenov I think you still have a few deletion change needs to be reverted |
@@ -1,123 +0,0 @@ | |||
<?xml version="1.0" encoding="utf-8"?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these resources not used anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes came from a revert change by Roberto earlier but I had to force push to wipe it so causing some confusion here. They are not meant to be included in the PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I missed those .. I'm sorry guys.
UI Smoke TestsTest: success. 2 passed, 0 failed. |
Purpose
Addresses this Jira issue: DYN-6821 Fixes HomePage links.
Declarations
Check these if you believe they are true
*.resx
filesRelease Notes
Reviewers
@reddyashish
FYIs
@Amoursol