Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pm publish experience rework #14791

Closed
wants to merge 3 commits into from

Conversation

dnenov
Copy link
Collaborator

@dnenov dnenov commented Dec 19, 2023

Purpose

The new RetainFolder functionality of the Package Manager is still not providing the desired functionality. This PR tries to fix some of the logic behind it.

Changes

Dynamo_PublishVersion

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • changes the way Publish and Publish Version load assembly files when retaining folder structure toggle is on
  • stopped the ErrorString from being overridden when a specific condition is met leading to Resources.OneAssemblyWasLoadedSeveralTimesErrorMessage - this has not been tested fully, if it leads to some strange behavior later on
  • also removed the limitation to loading multiple binaries with the same name, but located in different folders when creating a new package. This will allow, when retaining folder toggle is on, to create custom packages if necessary. If the toggle is off and the default folder structure is used, the duplicate binaries will be pruned in a different part of the code

Reviewers

@mjkkirschner

FYIs

@reddyashish

- now retains the exact number of files when retaining folder structure
- publish and publish version using retained folders now working better than before
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

- added two new options to publish package allowing the retain folder structure from the get-go
Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@dnenov
Copy link
Collaborator Author

dnenov commented Jan 26, 2024

I believe the work in this PR is now picked up by @zeusongit with the following PR #14880. I will close it down now.

@dnenov dnenov closed this Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant