Improve package nodes visibility #14178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- shows a triangle marker in the lower-left corner of the node indicating custom package or python node - when zoomed-out, a purple border and icon indicates nodes from packages
- added node package name to tooltip section
- remove old code
reddyashish
approved these changes
Jul 19, 2023
- added null checks when retrieving dictionary colors
|
@dnenov I think there are some test failures on this PR job. The first 2 tests look flaky but can you run the other 3 and verify. |
reddyashish
approved these changes
Aug 1, 2023
- serialization changes to the new `PackageName` property - hard-coded color values inside the NodeViewModel
mjkkirschner
reviewed
Aug 2, 2023
| /// Returns the Package name of the node, if it comes from a package | ||
| /// </summary> | ||
| [JsonProperty(Order = 9)] | ||
| public string PackageName |
There was a problem hiding this comment.
why is this being serialized? It looks like you never read the serialized data? I imagine this data is duplicated by the NodeLibraryDependencies property.
There was a problem hiding this comment.
You are right, I will just ignore it, apologies!
There was a problem hiding this comment.
Big thanks for this spot check, @mjkkirschner , hopefully it's fixed with this PR
mjkkirschner
reviewed
Aug 2, 2023
| "X": 76.8, | ||
| "Y": 162.4 | ||
| "Y": 162.4, | ||
| "PackageName": "" |
There was a problem hiding this comment.
kind of pointless bloat for every single node...
There was a problem hiding this comment.
Yup, totally! Thanks again
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
A visual update to the Node border to package nodes. In zoomed-out state, a purple border allows the user to easily distinguish between Dynamo core nodes and external, package nodes. The bottom-left corner of the Node is now tinted with the same color as the workspace background again allowing the user to quickly see which nodes come from external packages. Finally the package name, as filled-in by the package owner, is shown inside the node tooltip.
Screenshots of UI changes
Border states
Package names
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
come from a package.
Reviewers
@reddyashish
@mmisol
FYIs
@QilongTang