Add option to preview or hide preview of all geometry in a group and Fix top menu pixel difference #13702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeusongit
changed the title
zeusongit
commented
Jan 25, 2023
Comment on lines
-798
to
-804
| private double GetPortVerticalOffset(PortModel portModel, int proxyPortIndex) | ||
| { | ||
| // calculate the vertical offset based on the port index. | ||
| double portHeight = portModel.Height; | ||
| return verticalOffset + (proxyPortIndex * portHeight) + portVerticalMidPoint; | ||
| } | ||
|
|
There was a problem hiding this comment.
Removed because unused method
zeusongit
requested review from
filipeotero,
RobertGlobant20 and
mjkkirschner
filipeotero
reviewed
Jan 26, 2023
| @@ -1348,6 +1361,27 @@ private bool BelongsToGroup() | |||
| return WorkspaceViewModel.Model.Annotations.ContainsModel(this.annotationModel); | |||
| } | |||
|
|
|||
| internal void ToggleIsVisibleGroup(object parameters) | |||
| { | |||
| DynamoSelection.Instance.ClearSelection(); | |||
There was a problem hiding this comment.
why is it necessary to clear the selection?
There was a problem hiding this comment.
Just to clear any other groups/notes/nodes that may be present in the selection, as we only want to target the current group and its contents.
|
LGTM with one question |
filipeotero
approved these changes
Jan 26, 2023
|
@zeusongit - can we please change the text here from "Preview" to "Preview Geometry"? And also make that change inside the single node variant of Preview? Should both simply be textual changes. |
|
Updated Menu Text |
zeusongit
added a commit
to zeusongit/Dynamo
that referenced
this pull request
Feb 6, 2023
…Fix top menu pixel difference (DynamoDS#13702) * Adjust border to fix 1 pixel anomaly * remove unused login grid * add logic to toggle preview for group * add analytics * Preview > Preview Geometry * ensure that signout option no seen when user sign out
7 tasks
zeusongit
added a commit
that referenced
this pull request
Feb 7, 2023
* Dyn 5347 unified UI information icons (#13706) * standardizing information icons in the preference settings * Defending code (#13696) * Defending code * refining code * Improve Package Manager search sort order (#13700) * add search sort order * Add option to preview or hide preview of all geometry in a group and Fix top menu pixel difference (#13702) * Adjust border to fix 1 pixel anomaly * remove unused login grid * add logic to toggle preview for group * add analytics * Preview > Preview Geometry * ensure that signout option no seen when user sign out * DYN-4964-WorkingRange-Popup (#13656) * DYN-4964-WorkingRange-Popup I've added a new button in the Workspace that when is clicked will show a popup containing the working ranges and the one currently selected. This new button will show a different image when the mouse is hover and when is clicked, also I've added a tooltip. For implementing this functionality I've added a new Popup (GeometryScalingPopup.xaml) and it's corresponding ViewModel. Finally I've added a converter that will receive as a parameter the current Working Range and will return a Brush with a specific color so the checkmark will be visible or not. * DYN-4964-WorkingRange-Popup CodeReview1 Added functionality for the new DefaultGeometryScaling property that will be serialized in the DynamoSettings.xml. Also I've disconnected the functionality of selecting the Geometry Scale for the current Workspace in the Preferences panel, now will be selected from the Dynamo workspace and will be serialized in the dyn file (as currently is happening). * DYN-4964-WorkingRange-Popup CodeReview1 Updated the string shown in Preferences panel (Geometry Scaling section) and the tooltip showed when the mouse is over the new Workspace button. * Build Fix When merging master to my branch there were some changed that I didn't noticed in the PR so I'm reverting back those changes. * DYN-4964-WorkingRange-Popup CodeReview 2 Fixed several comments also several methods were removed (like RadioGeometryScaling_Checked method) or moved The property GeoScalingViewModel was moved from DynamoViewModel to WorkspaceViewModel.. The property CurrentGeometryScaling was deleted due that was duplicating a functionality. * DYN-4964-WorkingRange-Popup CodeReview 2 When changing the Workspace Geometry Scaling it was not running the graph so I did some changes so it will be running the graph every time is updated. * DYN-4964-WorkingRange-Popup CodeReview 2 Add functionality for when a custom node is created the Workspace Scale Factor is set. Updating and removing some comments and also I started to add the unit test. * DYN-4964-WorkingRange-Popup CodeReview2 Updating Unit Test * DYN-4964-WorkingRange-Popup Fixing Tests I did the next fixes: The test TestImportCopySettings() was failing due that was reading the DynamoSettings-NewSettings.xml and comparing against the properties in PreferencesSetting so the DefaultScaleFactor was missing in the DynamoSettings-NewSettings.xml file. The test PreferencesGeoScaling_RunGraph_Automatic due that was opening the Preferences panel and changing the Geometry Scaling value for the workspace but now that this value was moved to the Workspace in a Popup then the code needed some changes so we can change the Geometry Scaling value using the Popup. * Dyn 4964 popup geo scaling bugs (#13717) * DYN-4964-PopupGeoScaling-Bugs Fixing the next bugs reported by Aabi: - The Popup was not closing when clicking in the Dynamo workspace (adding a similar fix like the Workspace ContextMenu). - Adding a shadow over the new Geometry Scaling popup icon. * DYN-4964-WorkingRange-Popup Bug fixes There was a missing case that when the user click a Dynamo menu the Popup was not closing then I added some extra code to close it. * DYN-4964-WorkingRange-Popup Bug Code Review1 Removing extra trailing spaces. * Do not force user login for package search operation (#13725) * restrict user login for pkg search * check login state * Revert "Dyn 4964 popup geo scaling bugs (#13717)" This reverts commit 35005c3. * Revert "DYN-4964-WorkingRange-Popup (#13656)" This reverts commit a526390. * Markdown procedural image location (#13693) * Markdown procedural image location - fixed hard-coded image location - now identifies image location * Fixed Failing Tests - caught a bug causing issues when no image is present * Revert "Markdown procedural image location (#13693)" This reverts commit 299bbe9. * Address review comments for 2.17.1 cherrypick PR (#13729) --------- Co-authored-by: filipeotero <89042471+filipeotero@users.noreply.github.com> Co-authored-by: jesusalvino <96534278+jesusalvino@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://jira.autodesk.com/browse/DYN-5504
Before:
After:
https://jira.autodesk.com/browse/DYN-5257
Declarations
Check these if you believe they are true
*.resxfilesRelease Notes
Reviewers
@DynamoDS/dynamo
FYIs
@Amoursol @Jingyi-Wen