Update labels splash screen #13589
Merged
Update labels splash screen #13589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
QilongTang
reviewed
Dec 2, 2022
| errorDescription = Dynamo.Wpf.Properties.Resources.ImportPreferencesInfo; | ||
| break; | ||
| case ImportStatus.error: | ||
| importSettingsTitle = Dynamo.Wpf.Properties.Resources.SplashScreenFailedImportSettings; |
There was a problem hiding this comment.
Do we need to remove the corresponding resouces?
There was a problem hiding this comment.
Good call. Removing it...
QilongTang
approved these changes
Dec 2, 2022
|
Thanks @filipeotero Please cherry-pick |
filipeotero
added a commit
to filipeotero/Dynamo
that referenced
this pull request
Dec 2, 2022
* Update labels splash screen * removing unnecessary resources
filipeotero
added a commit
to filipeotero/Dynamo
that referenced
this pull request
Dec 2, 2022
* Update labels splash screen * removing unnecessary resources
8 tasks
QilongTang
pushed a commit
that referenced
this pull request
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Declarations
Check these if you believe they are true
*.resxfilesReviewers
@avidit @QilongTang