Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Package Dialog UI Refresh #2 #12206

Merged
merged 28 commits into from
Nov 1, 2021
Merged

Publish Package Dialog UI Refresh #2 #12206

merged 28 commits into from
Nov 1, 2021

Conversation

OliverEGreen
Copy link
Contributor

Purpose

This PR cherry-picks changes made from PR #12171, since that was based off a custom branch.

This PR Updates the styling of PackagePublishView and introduces new optional fields as per the visual refresh design:

gKqj62OxzV

  • The "Add Directory" button has been added, allowing a used to recursively add all files in a specific directory (and all subdirectories).
  • The Package Contents list has been redesigned as a DataGrid.
  • A new, optional Markdown Files Directory has been added.
  • A 'More Details' expander section has been added with new, optional fields, such as license type.
  • A clickable link to the MIT license has been added as per the new design.

Please Note: A follow-up PR will be needed to address the current discussion around loading/unloading DLLs. Current implementation of the Markdown functionality is setting a string property on the PublishPackageViewModel, the build process remains untouched for now.

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Reviewers

@QilongTang

FYIs

@Amoursol

Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once comments addressed, we should be good to go

@QilongTang QilongTang requested a review from sm6srw October 29, 2021 18:10
@QilongTang
Copy link
Contributor

Hi @sm6srw Let me know if you have anything on your end.

@sm6srw
Copy link
Contributor

sm6srw commented Nov 1, 2021

@QilongTang Nothing from me! I somehow assigned myself to the wrong Jira task.

@QilongTang QilongTang merged commit 848429e into DynamoDS:master Nov 1, 2021
@OliverEGreen OliverEGreen deleted the publish_package_dialog_ui_refresh branch November 9, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants