Undock extension views that provide a window #11309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extension views that provided a window rather than a control, like TuneUp, were not properly handled by docking/undocking. The content was being cast to a type that was too specific so it got lost. Also, opening the extension directly as a floating window would result in a crash because the content was not being unwrapped from the window in this case.
QilongTang
approved these changes
Dec 3, 2020
mmisol
added a commit
to mmisol/Dynamo
that referenced
this pull request
Dec 3, 2020
Extension views that provided a window rather than a control, like TuneUp, were not properly handled by docking/undocking. The content was being cast to a type that was too specific so it got lost. Also, opening the extension directly as a floating window would result in a crash because the content was not being unwrapped from the window in this case.
mmisol
added a commit
that referenced
this pull request
Dec 3, 2020
Extension views that provided a window rather than a control, like TuneUp, were not properly handled by docking/undocking. The content was being cast to a type that was too specific so it got lost. Also, opening the extension directly as a floating window would result in a crash because the content was not being unwrapped from the window in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Extension views that provided a window rather than a control, like
TuneUp, were not properly handled by docking/undocking. The content was
being cast to a type that was too specific so it got lost. Also,
opening the extension directly as a floating window would result in a
crash because the content was not being unwrapped from the window in
this case.
Declarations
Check these if you believe they are true
*.resxfilesFYIs
@Amoursol