Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom node dialog size #11300

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

mmisol
Copy link
Collaborator

@mmisol mmisol commented Dec 1, 2020

Purpose

Fixes the size of the custom node dialog so that buttons are not cut
outside of its boundaries when using a multi-line description.

Screenshot:
Screen Shot 2020-12-01 at 9 17 20 AM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated

Fixes the size of the custom node dialog so that buttons are not cut
outside of its boundaries when using a multi-line description.
Copy link
Contributor

@QilongTang QilongTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QilongTang QilongTang merged commit 4340648 into DynamoDS:master Dec 1, 2020
@QilongTang
Copy link
Contributor

@mmisol Would you also cherry-pick this to 2.10.0?

mmisol added a commit to mmisol/Dynamo that referenced this pull request Dec 3, 2020
Fixes the size of the custom node dialog so that buttons are not cut
outside of its boundaries when using a multi-line description.
mmisol added a commit that referenced this pull request Dec 3, 2020
Fixes the size of the custom node dialog so that buttons are not cut
outside of its boundaries when using a multi-line description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants