Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Report Python Issue Button Style #11263

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Update Report Python Issue Button Style #11263

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/Libraries/PythonNodeModels/Docs/PythonMigrationWarning.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,18 @@
display: none;
}

.button {
background-color: transparent;
border-color: #3c3c3c;
color: #bbbbbb;
}

.button:hover {
border-color: #656565;
background-color: #373737;
opacity: 1.0;
}

@media screen and (max-width: 600px) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but I wonder why we are using media queries when the panel was not even extendable until recently. Did we copy this content from somewhere else?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmisol These are all produced by MatterLab. Not so sure

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmisol Do you see any issue around the styling here around extend behavior? I can log follow up issue if you found any bug

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I did not understand the question. I do think the media query should be removed unless it actually provides noticeable improvements. At least to avoid the pitfall of running into similar issues again in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Looking into it. I was just wondering if you already noticed any bug

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I saw as difference
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the style difference in this case is nice to have so I'm ok with keeping the media query. Thanks for checking @QilongTang !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmisol Thanks for the checking, I did not notice this before

table {
width: 100%;
Expand Down Expand Up @@ -139,18 +151,6 @@
tbody tr:first-of-type {
border-bottom: none;
}

.button {
background-color: transparent;
border-color: #3c3c3c;
color: #bbbbbb;
}

.button:hover {
border-color: #656565;
background-color: #373737;
opacity: 1.0;
}
}
</style>

Expand Down