Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics tracking events on extension load #11258

Merged
merged 1 commit into from
Nov 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/DynamoCore/Extensions/ExtensionLoader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,11 @@ private IExtension Load(ExtensionDefinition extension)
var assembly = Assembly.LoadFrom(extension.AssemblyPath);
var result = assembly.CreateInstance(extension.TypeName) as IExtension;
ExtensionLoading?.Invoke(result);

Logging.Analytics.TrackEvent(
Actions.Load,
Categories.ExtensionOperations, extension.TypeName);

return result;
}
catch(Exception ex)
Expand Down
5 changes: 5 additions & 0 deletions src/DynamoCoreWpf/Extensions/ViewExtensionLoader.cs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ internal IViewExtension Load(ViewExtensionDefinition viewExtension)
var assembly = Assembly.LoadFrom(viewExtension.AssemblyPath);
var result = assembly.CreateInstance(viewExtension.TypeName) as IViewExtension;
ExtensionLoading?.Invoke(result);

Analytics.TrackEvent(
Actions.Load,
Categories.ExtensionOperations, viewExtension.TypeName);

return result;
}
return null;
Expand Down
15 changes: 15 additions & 0 deletions src/NodeServices/IAnalyticsClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,16 @@ public enum Categories
/// Events Category related to Python operations
/// </summary>
PythonOperations,

/// <summary>
/// Events Category related to Extensions operations
/// </summary>
ExtensionOperations,

/// <summary>
/// Events Category related to View Extensions operations
/// </summary>
ViewExtensionOperations,
}

/// <summary>
Expand Down Expand Up @@ -187,6 +197,11 @@ public enum Actions
/// Run event, such as Python node run clicked, Graph run Clicked
/// </summary>
Run,

/// <summary>
/// Load event, such as extensions loaded
/// </summary>
Load,
}

/// <summary>
Expand Down