Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null-check #11144

Merged

Conversation

aparajit-pratap
Copy link
Contributor

Add null-check

@aparajit-pratap aparajit-pratap merged commit 7c32a77 into DynamoDS:NodeAutoComplete Sep 24, 2020
@aparajit-pratap aparajit-pratap deleted the nodeautocomplete2 branch September 24, 2020 03:32
QilongTang added a commit that referenced this pull request Sep 29, 2020
* Initial Commit of NodeAutoComplete MVP

* Clean Up

* Fix a bug that left over search term was kept for next trigger

* Changed to use alt + mouse left key down and change cursor to adapt to connection mode

* Fix the in canvas node auto complete glitching issue with a click suppress

* Comments

* preference setting test

* Add test

* New Node AutoComplete

* Comments

* Comments

* Use node suggestion API in node autocomplete UI (#11132)

* update code comment

* add APIs to return matching nodes for input ports

* revert temporary changes made for testing

* cleanup

* merge api with UI

* revert unwanted changes

* Add null-check (#11144)

* add null-check

* Clean Up

* Moving GetMatchingNodes API to search view model (#11146)

* Moving GetMatchingNodes API to search view model

* Clean Up

* Comments

* Create a dedicated test file to prepare for more unit tests

* Comments

* Comments

* Comments

* Comments

Co-authored-by: aparajit-pratap <aparajit.pratap@autodesk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant