Skip to content

Commit

Permalink
Fix slider localization test (#15136)
Browse files Browse the repository at this point in the history
  • Loading branch information
reddyashish authored Apr 16, 2024
1 parent fa01cb7 commit dd7f87d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
7 changes: 4 additions & 3 deletions src/Libraries/CoreNodeModelsWpf/SliderViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ public T Value
if (value.CompareTo(model.Min) == -1)
model.Min = value;

var stepValueString = model.Step.ToString();
double.TryParse(model.Step.ToString(), out double stepValue);
var stepValueString = stepValue.ToString(null, CultureInfo.InvariantCulture);
var decimalPoints = 0;
if (stepValueString.Contains('.'))
{
Expand All @@ -73,8 +74,8 @@ public T Value
if (value is IFormattable formattableval)
{
var invariantString = formattableval.ToString(null,CultureInfo.InvariantCulture);
var sliderValue = Math.Round(decimal.Parse(invariantString), decimalPoints);
model.UpdateValue(new Dynamo.Graph.UpdateValueParams(nameof(Value), sliderValue.ToString()));
var sliderValue = Math.Round(decimal.Parse(invariantString, CultureInfo.InvariantCulture), decimalPoints);
model.UpdateValue(new Dynamo.Graph.UpdateValueParams(nameof(Value), sliderValue.ToString(CultureInfo.InvariantCulture)));
}
else
{
Expand Down
1 change: 0 additions & 1 deletion test/DynamoCoreWpfTests/SliderViewModelTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@ public void SliderViewModel_ValueTest()
/// modify the value.
/// </summary>
[Test]
[Category("Failure")]
public void SliderViewModel_ValueTest_Localized()
{
//change current thread culture to German.
Expand Down

0 comments on commit dd7f87d

Please sign in to comment.