Skip to content

Commit

Permalink
missed some property change notifications to update view (#11023) (#1…
Browse files Browse the repository at this point in the history
  • Loading branch information
mjkkirschner authored Aug 19, 2020
1 parent 9538d39 commit 4eaecde
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 8 deletions.
14 changes: 8 additions & 6 deletions src/DynamoCore/Graph/Nodes/NodeModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2297,15 +2297,17 @@ var port in
// in different ways and their views will always be up-to-date with
// respect to their models.
RaisePropertyChanged("InteractionEnabled");
RaisePropertyChanged("State");
RaisePropertyChanged("Name");
RaisePropertyChanged("ArgumentLacing");
RaisePropertyChanged("IsVisible");

RaisePropertyChanged(nameof(State));
RaisePropertyChanged(nameof(Name));
RaisePropertyChanged(nameof(ArgumentLacing));
RaisePropertyChanged(nameof(IsVisible));
RaisePropertyChanged(nameof(DisplayLabels));
RaisePropertyChanged(nameof(IsSetAsInput));
RaisePropertyChanged(nameof(IsSetAsOutput));
//we need to modify the downstream nodes manually in case the
//undo is for toggling freeze. This is ONLY modifying the execution hint.
// this does not run the graph.
RaisePropertyChanged("IsFrozen");
RaisePropertyChanged(nameof(IsFrozen));
MarkDownStreamNodesAsModified(this);

// Notify listeners that the position of the node has changed,
Expand Down
10 changes: 8 additions & 2 deletions src/DynamoCoreWpf/ViewModels/Core/NodeViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -806,8 +806,14 @@ void logic_PropertyChanged(object sender, PropertyChangedEventArgs e)
RaisePropertyChanged("Height");
UpdateErrorBubblePosition();
break;
case "DisplayLabels":
RaisePropertyChanged("IsDisplayingLables");
case nameof(NodeModel.DisplayLabels):
RaisePropertyChanged(nameof(IsDisplayingLabels));
break;
case nameof(NodeModel.IsSetAsInput):
RaisePropertyChanged(nameof(IsSetAsInput));
break;
case nameof(NodeModel.IsSetAsOutput):
RaisePropertyChanged(nameof(IsSetAsOutput));
break;
case "Position":
UpdateErrorBubblePosition();
Expand Down

0 comments on commit 4eaecde

Please sign in to comment.