Migrating to AndroidX

[vokhuyetOz]

No description provided.

[codecov]

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           1        1           
  Lines          19       19           
=======================================
  Hits           18       18           
  Misses          1        1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f080bf...40ec7e9. Read the comment docs.

[codecov]

Codecov Report

Merging #500 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #500   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           1        1           
  Lines          19       19           
=======================================
  Hits           18       18           
  Misses          1        1

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df76905...d81f856. Read the comment docs.

[WrathChaos]

Waiting for this PR...

[mkamals]

Kindly merge this PR soon and release a new version of the package. This is creating lot of issues with the build generation in Android.

[arunalt]

Hey @DylanVann,

Do we have any ETA on when this PR will get merged? We're looking to migrate to AndroidX and this is a huge dependency for us. Would really appreciate a response!

Cheers.
Arun.

[rborn]

@DylanVann I can confirm the PR works well (I'm using it now as replacement for this one till it gets merged)
@vokhuyetOz maybe you could rebase so the PR can be merged when the time comes ? ❤️

[die20]

For some reason when I try to fork this branch and try to use it in an application, I get this when I run yarn install:

fatal: not a git repository (or any of the parent directories): .git
error Command failed with exit code 128.

This is how I'm trying to use it on the package.json:

"react-native-fast-image": "git+https://github.com/vokhuyetOz/react-native-fast-image",

[rborn]

@die20
"react-native-fast-image": "git+https://github.com/vokhuyetOz/react-native-fast-image.git",

you forgot the trailing .git 😊

[JimtotheB]

@rborn The trailing .git shouldn't matter, I can reproduce this behavior in a bare project, It also produced the same error with yarn add https://github.com/DylanVann/react-native-fast-image which is 100% the correct way to add a git repo via yarn

{
  "name": "fake",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "license": "ISC",
  "dependencies": {
    "lodash": "git+https://github.com/lodash/lodash"
  }

This works just fine. 😊

[rborn]

@JimtotheB this works for me, however it takes 1000 years to finish 😔

npm install -ddd https://github.com/DylanVann/react-native-fast-image.git

[JimtotheB]

@rborn, I think this is specific to yarn, I'm sure npm is unpacking the submodule correctly and yarn is not.

[die20]

@rborn It seems to be a yarn issue. It's not just this branch though, it's the master of react-native-fast-image.

I was able to get it installed with npm but remote gifs appear to not be working with this commit. The gif does not play.

[Ilphrin]

Thanks for this PR =D
There will be a need for an approval now that RN 60 is out, it needs AndroidX support for all libraries so until this PR is merged, react-native-fast-image may not work anymore on Android for 0.60 :/ We do not use this version yet so can't test yet though...

[DylanVann]

I have tried this PR, it does work with the new RN version by default.

The one thing blocking me from merging is that the example application includes other 3rd party libraries that do not support AndroidX.

[vokhuyetOz]

@DylanVann i saw react-native-gesture-handle don't migrate to androidX, it causes the error

[vokhuyetOz]

should we wait for it ?

[DylanVann]

I used jetify to fix the examples. This is great, thanks @vokhuyetOz! I ended up merging from another branch.

[mkamals]

Thanks @DylanVann for merging this PR.