FEATURE/COTENT: FISHING + MORE CONTENT #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OcelotWalrus
added
documentation
Closed
|
Hey @lumbar527, happy new year! Would you mind giving this PR a review? You don't necessarily have to bother to look into the code and stuff, I'm just looking for a review of the mechanics and such. |
TheGiraffe3
reviewed
Jan 2, 2025
OcelotWalrus
commented
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTENT/FEATURE
This PR addresses the bug/feature described in issue #107
This PR addresses the game progression goal #Add fishing features
Summary
These PR has three main points:
Fishing Feature
It first adds the fishing feature described in #107. Fishing is a brand new UI inside the main UI, where the player can try to catch fishes or any item using the combination of a Fishing Rod item and a Lure item, combining both of their stats. You can fish by running the main command
Fwhen at a map point that's next to a map zone of typeseaorlake. Each sea or lake map zone type now has in its definition the list of items that're possible to be caught when fishing there. Fishing requires you to have at least one fishing rod item and one lure item in your inventory, that you'll equip once in the fishing UI. Fishing rods and lures cam be bought in pretty much any civilization selling map zone.Fishing rod have the two following stats:
speed coefficientandrod strength. Thespeed coefficientattribute is a coefficient that changes how fast the delay time between fishing and having a fish on is. If the speed coefficient is set to 2, it'll be two time faster than normal, thus it's a decimal percentage. Whereasrod strengthdetermines how heavy of a catch the rod can handle, as items have gotten a new optional attribute:fishing weight. Now about the lure, it's got two attribute:speed coefficientandpreferred types. Thespeed coefficientattribute of the lure works the same as the rod's, it's just combined to it in the equation. Thepreferred typesattribute defines which items will be granted more probability of being caught when fishing than others.Once a fish is caught, you'll see another UI, pretty similar to the fighting UI, as you'll 'fight' with the fish, by either pulling or restoring stamina etc. Once you catch a fish, you get it in your inventory, and receive some experience points. Note that each fish has a really nice colorful ASCII art with it, that you can view in your inventory or your diary.
Diary Enhancements
First of all, the general diary UI has been enhanced with more colors and separators to organize the stuff around. The
Encountered Monsterstab was renamed toEnemiesandEncountered PeopleintoPeople. A new tab forFishinghas been added to. Each tab has gotten brand new stats for the joy of the player:Enemies//NUMBER OF KNOWN ENEMIES SPECIESNUMBER OF COMBATSAMOUNT OF DAMAGE DEALTAMOUNT OF DAMAGE TAKENAMOUNT OF HEALTH RECOVEREDPeople//NUMBER OF KNOWN PEOPLETasks//NUMBER OF MISSIONS OFFEREDNUMBER OF MISSIONS COMPLETEDNUMBER OF MISSIONS FAILEDFishing//NUMBER OF FISH CAUGHTNUMBER OF FISH MISSEDNUMBER OF FISH ENCOUNTEREDFISH CAUGHT WORTH IN GOLDKNOWN FISHING LOCATIONSFISHES CAUGHT# stat for each encountered fish speciesSPECIESESTIMATED VALUENUMBER OF TIMES ENCOUNTEREDNUMBER OF TIMES CAUGHTNUMBER OF TIMES MISSEDContent Add-ons
As with the fishing feature, many new fish items have been added:
With that, fishing rods and lures:
A new mount, the
Fellbeasthas also been added, being the most powerful mount by now.Finally, a new dungeon in progress present in the arid lands of Kirgon in the new isle of Shire has been added, with that new fresh techniques to make dungeons and brand new content:
one shotandnever run awayenemy attributesScreenshots
Gameplay Shots
Save File
This save file can be used to test these changes:
Save Data
Performance Impact
N/A
Check-List
{{If this PR is in progress, write major actions that need to be done here.}}