Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some typoes #103

Merged
merged 7 commits into from
Jul 17, 2024
Merged

Fix some typoes #103

merged 7 commits into from
Jul 17, 2024

Conversation

TheGiraffe3
Copy link
Contributor

@TheGiraffe3 TheGiraffe3 commented Jul 16, 2024 •
edited
Loading

Typo Fix

This PR addresses the bug/feature described in issue none
This PR addresses the game progression goal none

Summary

Fixed typos.

Screenshots

No.

Usage examples

N/A

Testing Done

No.

Testing Method

None.

Save File

This save file can be used to test these changes:
None.

Performance Impact

N/A

Check-List

N/A

@TheGiraffe3 TheGiraffe3 changed the title Fix some typos in the README Fix some typos Jul 16, 2024
@TheGiraffe3
Copy link
Contributor Author

TheGiraffe3 commented Jul 16, 2024 •
edited
Loading

I'm not sure why the checks are failing, they don't seem to have anything to do with my changes.

@OcelotWalrus
Copy link
Member

That's because you use " (normal quotes) instead of “ and ” (curly quotes). If you use normal quotes, the yaml parser gets wrong because it's used to define strings. So until a normal quote gets closed by an other one, the parser consider that space between as a whole string.

OcelotWalrus
OcelotWalrus reviewed Jul 16, 2024
View reviewed changes
Copy link
Member

@OcelotWalrus OcelotWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than that, the PR seems good.

@OcelotWalrus OcelotWalrus changed the title Fix some typos Fix some typoes Jul 16, 2024
@TheGiraffe3
Copy link
Contributor Author

... so... the lesson is don't change quotation marks.

@TheGiraffe3 TheGiraffe3 requested a review from OcelotWalrus July 17, 2024 03:53
@OcelotWalrus
Copy link
Member

Well, not the normal ones.

@OcelotWalrus OcelotWalrus merged commit a8958f8 into Dungeons-of-Kathallion:master Jul 17, 2024
12 checks passed
@TheGiraffe3 TheGiraffe3 deleted the patch-1 branch July 17, 2024 04:31
@OcelotWalrus
Copy link
Member

You're actually making me wanna reinvest on this project. It'd nice to have the planned plot at least.

OcelotWalrus pushed a commit that referenced this pull request Jul 19, 2024
@TheGiraffe3 @OcelotWalrus
fix - removed typoes (#103)
cb4fe27
@OcelotWalrus OcelotWalrus self-assigned this Jul 24, 2024
@OcelotWalrus OcelotWalrus added the text - short This PR/issue proposes text changes that are short label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OcelotWalrus OcelotWalrus OcelotWalrus approved these changes

Assignees

@OcelotWalrus OcelotWalrus

Labels
text - short This PR/issue proposes text changes that are short
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheGiraffe3 @OcelotWalrus