Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aging dependencies and Python 3.7 #160

Closed
fabricebrito opened this issue Nov 20, 2023 · 2 comments · Fixed by #161
Closed

Aging dependencies and Python 3.7 #160

fabricebrito opened this issue Nov 20, 2023 · 2 comments · Fixed by #161
Assignees

Comments

@fabricebrito
Copy link
Collaborator

Calrissian relies on Python 3.7 and old pinned dependencies.

  • support newer Python versions
  • support higher versions for the dependencies
@fabricebrito fabricebrito self-assigned this Nov 20, 2023
fabricebrito added a commit that referenced this issue Nov 20, 2023
@fabricebrito
Copy link
Collaborator Author

@mr-c do you have any hints on why this test https://github.com/Duke-GCB/calrissian/blob/issue-160/tests/test_job.py#L46 is failing with an update of the dependency shellescape==3.8.1 (instead of shellescape==3.4.1?
It uses needs_shell_quoting_re = re.compile(r"""(^$|[\s|&;()<>\'"$@])""") from cwltool's job.py

@mr-c
Copy link
Contributor

mr-c commented Nov 20, 2023

@mr-c do you have any hints on why this test https://github.com/Duke-GCB/calrissian/blob/issue-160/tests/test_job.py#L46 is failing with an update of the dependency shellescape==3.8.1 (instead of shellescape==3.4.1? It uses needs_shell_quoting_re = re.compile(r"""(^$|[\s|&;()<>\'"$@])""") from cwltool's job.py

I don't, no.

That's the versions we've been testing with: https://github.com/common-workflow-language/cwltool/actions/runs/6932721232/job/18861573891?pr=1938#step:7:168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants