Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps) & feat: support Next's new logging style, added PluginOptions.browserslist #84

Merged
merged 10 commits into from
Sep 16, 2023

Conversation

DuCanhGH
Copy link
Owner

@DuCanhGH DuCanhGH commented Sep 16, 2023

Changes:

  • Added PluginOptions.browserslist

    • This defaults to "chrome >= 56", same with Workbox's default.

    • Note that .browserslistrc, package.json.browserslist, etc. are not supported (yet), and the only way to pass the config to next-pwa is PluginOptions.browserslist, but you can read the file yourself, parse it, then pass it to next-pwa.

    • This allows you to configure which browsers you want to target your workers for. This tells next-pwa to add PluginOptions.workboxOptions.babelPresetEnvTargets if that option is not defined, which means that the service worker will, too, be bundled to target these browsers, but you can change that by adding the option.

  • Support Next's new logging style

    • So Next changed its logging style again, and I'm wondering if trying to match its logging style is even a good idea.

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

🦋 Changeset detected

Latest commit: a1eb564

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ducanh2912/next-pwa Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant