Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force consumers to use jetifier #71

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Don't force consumers to use jetifier #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion buildSrc/src/main/kotlin/Dependencies.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ object Dependencies {
const val hyperionAppInfo = "com.star-zero:hyperion-appinfo:2.0.0"
const val chucker = "com.github.ChuckerTeam.Chucker:library:3.5.2"
const val deviceNames = "com.jaredrummler:android-device-names:2.1.0"
const val debugDb = "com.github.amitshekhariitbhu.Android-Debug-Database:debug-db:1.0.6"

// debug-db uses legacy appcompat dependencies, using @aar will not force consumers to run jetifier on their side
const val debugDb = "com.github.amitshekhariitbhu.Android-Debug-Database:debug-db:1.0.6@aar"

const val multidex = "androidx.multidex:multidex:2.0.1"
const val androidGradlePlugin = "com.android.tools.build:gradle:7.3.1"
const val kotlinGradlePlugin = "org.jetbrains.kotlin:kotlin-gradle-plugin:1.7.20"
Expand Down
6 changes: 5 additions & 1 deletion foqa/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,11 @@ dependencies {
api(Dependencies.chucker)
api(platform(Dependencies.okHttpBom))
api(Dependencies.okHttp)
implementation(Dependencies.debugDb)
implementation(Dependencies.debugDb) {
// debugDb uses legacy appcompat dependencies, making it transitive will not force consumers
// to run jetifier on their side
isTransitive = true
}

implementation(project(":device_info_plugin"))
implementation(project(":font_scale_plugin"))
Expand Down