Allowing dark theme for system theme matching to be changed. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dark theme list from resources when it's split.
property to libportablethemeengine.
Moved the radio button checkboxes to the top-right when necessary and aligned the controls better.
a matching theme in case the user wants to choose something else.
back to the default in the same session.
so it's more clear as "defaultDarkTheme" could be confusing if there's a default default dark theme.
DrewNaylor
added
the
on changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the dark theme to apply when the user wants to match the system theme can be changed from the new default of
ProDarkback toTenDarkor toMaudern. This list of dark themes is stored in the Resources and can be updated at any time. Please be aware that unlike the theme list, specifying an unrecognized dark theme in the config file won't add it to the list of dark themes.Additional changes in this PR:
ProDarkis the new default dark theme.darkthemeForSystemThemeMatching: String; defaults toProDarkMaudern,ProDark, andTenDark.PortableThemeEngineas well. In that case, calling applications would change thelibportablethemeengine.ThemeEngine.DarkThemeForSystemThemeMatchingproperty. After applying a dark theme in this way, this property will be overwritten withProDarkagain in case the calling app wants to use the default after changing it to a different theme.Personalizationtab has been renamed toThemeand the statusbar options have been moved to their own tab to allow the dark theme for system theme matching settings to go on theThemetab.Tools>Options...>Theme, then change the dark theme dropdown below the mainAppearancegroupbox to what you want, and clickOK. Please be aware that this setting won't take effect unless theMatch Windows 10 theme settingscheckbox is checked and the theme engine is running.My.Settings.darkthemeForSystemThemeMatching, thenProDarkwill be used instead and will be what the Options window displays in the dropdown.PortableThemeEngineDebuggernow supports matching the system theme, and changing to one of the three available dark themes if desired.UXLLauncher_ThemeEngineandPortableThemeEngineto 1.04 and 2.1, respectively.