Add extended color enum support #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicmosc
added
enhancement
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
larsbs
approved these changes
Dec 7, 2021
LeopoldArkham
requested changes
Dec 7, 2021
| v === `${match[0]}.${value?.description || value}` || | ||
| v === `${match[1]}.${value?.description || value}`)) : value; | ||
|
|
||
| // const finalValue = isEnum ? (type?.name || '') + '.' + (value?.description || value) : value; |
There was a problem hiding this comment.
Old line left behind it looks like
There was a problem hiding this comment.
forgot to push earlier ffs
LeopoldArkham
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes the defined colors in the style vars
And adds a proper enum for them, with support in the
Tagcomponent for now only