-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/global style option #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request contains a valid label.
Just to confirm, this is a way to avoid styles from a parent app to cascade down to a frame of the screen using drylus right? |
@Bartmr actually it's the opposite: The theme provider from drylus needs to add styling to the |
@nicmosc Got it. already clicked approve |
Allow
injectGlobal
option ofThemeProvider
/DrylusProvider
to be disabled when using Drylus in a pre-existing, non-drylus app e.g. Marketplace.This change makes it so that the styling of drylus-driven components/features is more isolated by making fonts relative to their closest font-setting parent (e.g.
ThemeProvider
when using theinjectGlobal=false
option).If the option is not disabled, then styles are injected globally like before (in fully drylus apps), so nothing is affected visually.