Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shell.nix: Override to fix jekyll on macOS #12

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

infinisil
Copy link
Contributor

@infinisil infinisil commented Jan 12, 2020

This fixes an error in the nix version of jekyll on darwin when running jekyll serve --config _config_local.yml. The error was:

/nix/store/hk9w40f7y8qpi413yjfkh3p98kcp5jli-ruby2.6.5-ffi-1.11.2/lib/ruby/gems/2.6.0/gems/ffi-1.11.2/lib/ffi/library.rb:273:in `attach_function': 
  Function 'libsass_version' not found in [/nix/store/ci77rd3c79y5hyjba66rymhmg7irjl8b-ruby2.6.5-sassc-2.2.1/lib/ruby/gems/2.6.0/gems/sassc-2.2.1/lib/sassc/libsass.bundle] (FFI::NotFoundError)

Related tickets are

Applying a patch to a gem gets very annoying since nixpkgs's Ruby infrastructure doesn't seem to be made for easy overrides of this.

This PR is based on the branch of #11 (ping @zupo)

@infinisil
Copy link
Contributor Author

infinisil commented Jan 12, 2020

This could also be solved by:

  • Fixing the underlying problem in nixpkgs (Clang link time optimization for darwin NixOS/nixpkgs#19312), but that would take me ages if I can do it at all
  • Having disable lto flag for darwin + nix sass/sassc-ruby#166 be merged, waiting for a new release, waiting for a jekyll release that includes this sassc release, updating the jekyll package in nixpkgs, hoping that it's not too new of a jekyll version to backport to 19.03
  • Upstreaming this patch to nixpkgs itself, backporting it to 19.03, waiting until 19.03 receives a channel update or patching the current nixpkgs to use the nixpkgs patch from now-upstream

@zupo zupo merged commit 543116f into DragonPyConf:nix Jan 13, 2020
@infinisil infinisil deleted the nix-jekyll-darwin branch January 13, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants