实现pty，附带测试程序 #685
Merged
实现pty，附带测试程序 #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @fslongjin dragonosbot has assigned @fslongjin. Use |
dragonosbot
added
A-fs
|
设备驱动模型部分发生了更改，请进行审查 cc @fslongjin |
fslongjin
requested changes
Apr 4, 2024
kernel/src/driver/tty/tty_driver.rs
Outdated
| pub fn saved_termios(&self) -> &Vec<Termios> { | ||
| &self.saved_termios | ||
| } | ||
|
|
||
| #[inline] | ||
| pub fn flags(&self) -> TtyDriverFlag { | ||
| self.flags | ||
| } | ||
|
|
||
| #[inline] | ||
| fn lockup_tty(&self, index: usize) -> Option<Arc<TtyCore>> { |
kernel/src/driver/tty/pty/mod.rs
Outdated
|
|
||
| pub mod unix98pty; | ||
|
|
||
| lazy_static! { |
There was a problem hiding this comment.
这两个最好使用unified_init来初始化，使得它初始化时机更为确定，减少未来调试的难度。
| @@ -536,8 +585,8 @@ pub fn tty_init() -> Result<(), SystemError> { | |||
| // 将这两个设备注册到devfs，TODO：这里console设备应该与tty在一个设备group里面 | |||
| device_register(tty.clone())?; | |||
| device_register(console.clone())?; | |||
| devfs_register(tty.name, tty)?; | |||
| devfs_register(console.name, console)?; | |||
| devfs_register(&tty.name.clone(), tty)?; | |||
dragonosbot
added
S-等待作者修改
|
issue: #641 |
dragonosbot
added
the
T-virtulization
|
参考linux: 这个咱们开个新的issue发布任务吧。 |
fslongjin
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
实现pty功能，能够创建pty对进行通信