Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

把Device trait的set_class改为设置Weak指针,以避免循环引用问题。 #666

Merged

Conversation

fslongjin
Copy link
Member

Class里面存储的是设备的Arc,而Device又要求设备存储Class的Arc,这会导致循环引用,出现潜在的问题。

@fslongjin fslongjin added the A-driver Area: 驱动程序 label Mar 25, 2024
@dragonosbot
Copy link

r? @YJwu2023

dragonosbot has assigned @YJwu2023.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@dragonosbot dragonosbot added S-等待审查 Status: 等待assignee以及相关方的审查。 T-driver Relevant to the driver team, which will review and decide on the PR/issue. labels Mar 25, 2024
@dragonosbot
Copy link

tty驱动发生了更改,请进行审查

cc @GnoCiYeH

@fslongjin fslongjin merged commit 4256da7 into DragonOS-Community:master Mar 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-driver Area: 驱动程序 S-等待审查 Status: 等待assignee以及相关方的审查。 T-driver Relevant to the driver team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants