Fixed Defect in Test case for Biceps:R5025 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belagertem
requested changes
Sep 7, 2023
sdccc/src/main/java/com/draeger/medical/sdccc/manipulation/GRpcManipulations.java
Show resolved
Hide resolved
sdccc/src/main/java/com/draeger/medical/sdccc/manipulation/Manipulations.java
Outdated
Show resolved
Hide resolved
sdccc/src/main/java/com/draeger/medical/sdccc/manipulation/Manipulations.java
Outdated
Show resolved
Hide resolved
sdccc/src/main/java/com/draeger/medical/sdccc/manipulation/Manipulations.java
Outdated
Show resolved
Hide resolved
.../java/com/draeger/medical/sdccc/manipulation/precondition/impl/ConditionalPreconditions.java
Outdated
Show resolved
Hide resolved
.../java/com/draeger/medical/sdccc/manipulation/precondition/impl/ConditionalPreconditions.java
Outdated
Show resolved
Hide resolved
.../java/com/draeger/medical/sdccc/manipulation/precondition/impl/ConditionalPreconditions.java
Outdated
Show resolved
Hide resolved
.../java/com/draeger/medical/sdccc/manipulation/precondition/impl/ConditionalPreconditions.java
Outdated
Show resolved
Hide resolved
.../java/com/draeger/medical/sdccc/manipulation/precondition/impl/ConditionalPreconditions.java
Outdated
Show resolved
Hide resolved
.../java/com/draeger/medical/sdccc/manipulation/precondition/impl/ConditionalPreconditions.java
Outdated
Show resolved
Hide resolved
…on to ManipulationPreconditions.
…nshipPrecondition.
belagertem
requested changes
Sep 11, 2023
.../com/draeger/medical/sdccc/manipulation/precondition/impl/ManipulationPreconditionsTest.java
Outdated
Show resolved
Hide resolved
.../com/draeger/medical/sdccc/manipulation/precondition/impl/ManipulationPreconditionsTest.java
Outdated
Show resolved
Hide resolved
.../com/draeger/medical/sdccc/manipulation/precondition/impl/ManipulationPreconditionsTest.java
Outdated
Show resolved
Hide resolved
...in/java/com/draeger/medical/sdccc/tests/biceps/invariant/InvariantMessageModelAnnexTest.java
Outdated
Show resolved
Hide resolved
belagertem
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Requirement Biceps:R5025 applies to all DescriptionModificationReports. However, the Precondition of its SDCcc Test case could only trigger Crt and Del ReportParts. Hence, when a Device only support Upt ReportParts in DescriptionModificationReports then the Requirement is applicable to it, but it cannot satisfy the test case.
This PR solves this problem by letting the Test case use another Precondition that tries to trigger DescriptionModificationReports with Crt, Del and Upt ReportParts.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: