Detect encoding problems #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns EnableEncodingCheck and SummarizeEncodingProblems.
maximilianpilz
requested changes
Jun 27, 2023
sdccc/src/main/java/com/draeger/medical/sdccc/messages/MessageStorage.java
Outdated
Show resolved
Hide resolved
sdccc/src/main/java/com/draeger/medical/sdccc/messages/MessageStorage.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/messages/TestMessageStorage.java
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/messages/TestMessageStorage.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/messages/TestMessageStorage.java
Outdated
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/messages/TestMessageStorage.java
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/messages/TestMessageStorage.java
Show resolved
Hide resolved
sdccc/src/test/java/com/draeger/medical/sdccc/messages/TestMessageStorage.java
Show resolved
Hide resolved
…Storage.java Co-authored-by: Maximilian Pilz <maximilian.pilz.git@gmail.com>
…eger/SDCcc into detect_encoding_problems
…the encoding determined for the message is also used to decode it.
maximilianpilz
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SDCcc currently accepts the encoding specified in a message and uses it to decode the message. When the encoding is specified incorrectly or the message contains characters that are not mappable using the specified encoding, then they are replaced by Charset-specific default characters, which may lead to False-positives or False-negatives in Test Cases that rely on messages stored in the database.
A much better approach would be to check the encoding while decoding the messages and to raise an Encoding Error when decoding a message with the specified encoding fails. As usual, these Encoding Errors can be managed using the EnableMessageEncodingCheck and SummarizeMessageEncodingErrors configuration options.
Checklist
The following aspects have been respected by the author of this pull request, confirmed by both pull request assignee and reviewer: