fix(diagnostics): absence of diagnostic should return None instead of…

… empty Vec
DrWursterich · Apr 18, 2024 · 15dddd2 · 15dddd2
1 parent 2edf82e
commit 15dddd2
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/command/mod.rs b/src/command/mod.rs
@@ -102,17 +102,20 @@ pub(crate) fn diagnostic(request: Request) -> Result<Message> {
             Message::Response(match diagnostic::diagnostic(params) {
                 Ok(diagnostic) => Response {
                     id: request.id,
-                    result: serde_json::to_value(FullDocumentDiagnosticReport {
-                        result_id: None,
-                        items: diagnostic,
-                    })
-                    .ok(),
+                    result: match diagnostic.len() {
+                        0 => None,
+                        _ => serde_json::to_value(FullDocumentDiagnosticReport {
+                            result_id: None,
+                            items: diagnostic,
+                        })
+                        .ok(),
+                    },
                     error: None,
                 },
                 Err(err) => err.to_response(request.id),
             })
         })
-        .map_err(|err| Error::from(err));
+        .map_err(Error::from);
 }
 
 pub(crate) fn highlight(request: Request) -> Result<Message> {