merge #11
Merged
merge #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osted by this repository (#10812) * docs/provider: Remove source content for guides which are no longer hosted by this repository Historically we have left the source for these guides in this repository for open source contribution even after they were migrated to the learn.hashicorp.com (which has its own source files). This has been okay up until this point with some manual synchronization of changes, however they will now show up unexpectedly in the Terraform Registry documentation if left here. * docs/provider: Replace relative IAM Policy Document Guide links with learn.hashicorp.com URL
…sting when no environment variables are present (#10850) * resource/aws_lambda_function: Expand kms_key_arn documentation and testing when no environment variables are present Reference: #6366 Output from acceptance testing: ``` --- PASS: TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables (56.91s) ``` * tests/resource/aws_lambda_function: Add more information to TestAccAWSLambdaFunction_KmsKeyArn_NoEnvironmentVariables test comment
add cloudwatch for target group and load balancer. I could only 1 find good example of how to do this using Google, so thought it would be good to add to the docs.
dimensions = {
TargetGroup = ""
LoadBalancer = ""
}
website: Small markdown formatting fix
…ket errors due to eventual consistency Reference: #10068 Previously, our acceptance testing would report eventual consistency issues such as: ``` --- FAIL: TestAccAWSS3Bucket_tagsWithSystemTags (11.28s) testing.go:615: Step 0 error: errors during apply: Error: error getting S3 bucket tags: NoSuchBucket: The specified bucket does not exist --- FAIL: TestAccAWSCodeBuildProject_Artifacts_ArtifactIdentifier (7.39s) testing.go:615: Step 0 error: errors during apply: Error: error getting S3 bucket tags: NoSuchBucket: The specified bucket does not exist ``` The `aws_s3_bucket` resource tends to call our `retryOnAwsCode()` helper function to deal with this type of eventual consistency issue so we also add that handling to this API call as well. Output from acceptance testing (after retrying any failing tests due to other read-after-write eventual consistency issues): ``` --- PASS: TestAccAWSS3Bucket_acceleration (57.29s) --- PASS: TestAccAWSS3Bucket_basic (32.63s) --- PASS: TestAccAWSS3Bucket_Bucket_EmptyString (30.76s) --- PASS: TestAccAWSS3Bucket_Cors_Delete (29.45s) --- PASS: TestAccAWSS3Bucket_Cors_EmptyOrigin (32.09s) --- PASS: TestAccAWSS3Bucket_Cors_Update (55.25s) --- PASS: TestAccAWSS3Bucket_disableDefaultEncryption_whenDefaultEncryptionIsEnabled (52.43s) --- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenAES256IsUsed (30.94s) --- PASS: TestAccAWSS3Bucket_enableDefaultEncryption_whenTypical (61.25s) --- PASS: TestAccAWSS3Bucket_forceDestroy (26.03s) --- PASS: TestAccAWSS3Bucket_forceDestroyWithEmptyPrefixes (26.81s) --- PASS: TestAccAWSS3Bucket_forceDestroyWithObjectLockEnabled (33.29s) --- PASS: TestAccAWSS3Bucket_generatedName (31.31s) --- PASS: TestAccAWSS3Bucket_LifecycleBasic (78.75s) --- PASS: TestAccAWSS3Bucket_LifecycleExpireMarkerOnly (52.02s) --- PASS: TestAccAWSS3Bucket_Logging (49.71s) --- PASS: TestAccAWSS3Bucket_namePrefix (30.67s) --- PASS: TestAccAWSS3Bucket_objectLock (52.31s) --- PASS: TestAccAWSS3Bucket_Policy (70.45s) --- PASS: TestAccAWSS3Bucket_region (29.50s) --- PASS: TestAccAWSS3Bucket_Replication (223.64s) --- PASS: TestAccAWSS3Bucket_ReplicationConfiguration_Rule_Destination_AccessControlTranslation (141.38s) --- PASS: TestAccAWSS3Bucket_ReplicationExpectVersioningValidationError (35.00s) --- PASS: TestAccAWSS3Bucket_ReplicationSchemaV2 (231.22s) --- PASS: TestAccAWSS3Bucket_ReplicationWithoutPrefix (67.87s) --- PASS: TestAccAWSS3Bucket_RequestPayer (53.47s) --- PASS: TestAccAWSS3Bucket_shouldFailNotFound (13.40s) --- PASS: TestAccAWSS3Bucket_tagsWithNoSystemTags (94.76s) --- PASS: TestAccAWSS3Bucket_tagsWithSystemTags (144.59s) --- PASS: TestAccAWSS3Bucket_UpdateAcl (53.37s) --- PASS: TestAccAWSS3Bucket_WebsiteRedirect (77.20s) --- PASS: TestAccAWSS3Bucket_WebsiteRoutingRules (57.40s) ```
…er-aws into biohazd-patch-1 I'm making a quick change to the example to use tf 0.12 formatting for all values
…try-GetBucketTagging resource/aws_s3_bucket: Retry GetBucketTagging API calls on NoSuchBucket errors due to eventual consistency
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: