Don't call self.close() in __del__, fixes Zulko#1994 (Zulko#1995)

Dotrar · Jul 11, 2023 · bc8d1a8 · bc8d1a8
1 parent e163cf5
commit bc8d1a8
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/moviepy/Clip.py b/moviepy/Clip.py
@@ -635,7 +635,10 @@ def __getitem__(self, key):
             return self.get_frame(key)
 
     def __del__(self):
-        self.close()
+        # WARNING: as stated in close() above, if we call close, it closes clips even
+        # if shallow copies are still in used, leading to some bugs: https://github.com/Zulko/moviepy/issues/1994
+        # so don't call self.close() here, rather do it manually in the code.
+        pass
 
     def __add__(self, other):
         # concatenate. implemented in specialized classes