Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test project for c# 13 (pre-release version) #3864

Merged

Conversation

bjornhellander
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.

Project coverage is 97.45%. Comparing base (ff5c432) to head (e239f6c).
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3864   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files         926      931    +5     
  Lines      110237   110279   +42     
  Branches     3315     3315           
=======================================
+ Hits       107433   107474   +41     
- Misses       1837     1838    +1     
  Partials      967      967           

@bjornhellander
Copy link
Contributor Author

@sharwell, I created this mostly to check if there were any regressions so far. None found. Some previous Roslyn problems were fixed and some tests which have syntax errors in them got slightly different behavior, but looks good so far. If you think it is too early to merge this now, I can update this now and then until the time is right.

I added LanguageVersionEx.CSharp13 the way I expect it will be defined eventually even though it was not in place yet.

What do you think?

@sharwell
Copy link
Member

Also need to incorporate this to https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/build/build-and-test.yml

@bjornhellander
Copy link
Contributor Author

Added that one and test.yml to the solution so they are easier to remember :-)

sharwell
sharwell previously approved these changes Jun 26, 2024
@bjornhellander bjornhellander force-pushed the feature/csharp13-tests branch from 3200afd to e239f6c Compare July 27, 2024 08:16
@bjornhellander bjornhellander marked this pull request as ready for review July 27, 2024 08:43
@sharwell sharwell merged commit 2dc4507 into DotNetAnalyzers:master Aug 22, 2024
21 checks passed
@bjornhellander bjornhellander deleted the feature/csharp13-tests branch August 23, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants