Update stylecop.json schema to have correct default for headerDecoration.
#3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration`. The default is documented to be the empty string, and since it's typed as `string`, `null` is not actually a valid value and will fail to validate.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3842 +/- ##
==========================================
+ Coverage 94.38% 97.45% +3.07%
==========================================
Files 925 925
Lines 110065 110092 +27
Branches 3307 3308 +1
==========================================
+ Hits 103881 107288 +3407
+ Misses 5174 1840 -3334
+ Partials 1010 964 -46 |
|
The default values need to also be updated in these two locations: |
sharwell
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default is documented to be the empty string, and since it's typed as
string,nullis not actually a valid value and will fail to validate.