Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename SA1652 to SA0001 and improve messaging #2031

Merged
merged 2 commits into from
Jan 7, 2016
Merged

Rename SA1652 to SA0001 and improve messaging #2031

merged 2 commits into from
Jan 7, 2016

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jan 7, 2016

Fixes #2030

@sharwell sharwell self-assigned this Jan 7, 2016
@sharwell sharwell added this to the 1.1.0 Beta 1 milestone Jan 7, 2016
@codecov-io
Copy link

Current coverage is 93.40%

Merging #2031 into master will increase coverage by +0.06% as of 111d6bf

@@            master   #2031   diff @@
======================================
  Files          561     561       
  Stmts        35580   35587     +7
  Branches      2283    2283       
  Methods                          
======================================
+ Hit          33212   33240    +28
+ Partial        751     749     -2
+ Missed        1617    1598    -19

Review entire Coverage Diff as of 111d6bf

Powered by Codecov. Updated on successful CI builds.

@vweijsters
Copy link
Contributor

👍 Looks good to me

@sharwell sharwell assigned vweijsters and unassigned sharwell Jan 7, 2016
sharwell added a commit that referenced this pull request Jan 7, 2016
@sharwell
Merge pull request #2031 from sharwell/fix-2030
9e71f5d 
Rename SA1652 to SA0001 and improve messaging
@sharwell sharwell merged commit 9e71f5d into DotNetAnalyzers:master Jan 7, 2016
@sharwell sharwell deleted the fix-2030 branch January 7, 2016 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vweijsters vweijsters

Labels
None yet
Projects
None yet
Milestone
1.1.0 Beta 1
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @codecov-io @vweijsters