update ordering diagnostics to proper StyleCop order #1128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oatkins Can you review the tests included in this for accuracy? |
|
The tests look good. It looks as though we have a large block of correctly ordered code that is used in the tests for multiple rules. Perhaps this could be refactored into a common location? It also seems to be missing a nested static class, for completeness. I'm going to merge this branch into the version I'll use on my machine today, so I should find any remaining gremlins pretty quickly. |
|
Good catch. I'll get those added. Looks like the diagnostic messages should be updated on 1203, 1204, 1214, and 1215. They don't include the access level and could be misleading. |
Closed
| @@ -0,0 +1,26 @@ | |||
| namespace StyleCop.Analyzers.OrderingRules | |||
There was a problem hiding this comment.
💡 Consider moving this to StyleCop.Analyzers.Helpers.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally found in 1204. The also applies to 1202, 1203, 1214, and 1215. 1215 was updated to match the diagnostic location style of the other diagnostic rules.
fixes #1123