SA1133CodeFixProvider crash

[vbfox]

Given the following code :

namespace Stylecop_rc1_bug_repro
{
    using System;

    internal class Program
    {
        [Foo, Bar]
        private static void Main(string[] args)
        {
        }
    }

    internal class FooAttribute : Attribute
    {
    }

    internal class BarAttribute : Attribute
    {
    }
}

SA1133 is raised on Bar usage but activating the CodeFix throw an exception :

Exception thrown: 'System.InvalidCastException' in StyleCop.Analyzers.CodeFixes.dll

Additional information: Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Syntax.AttributeListSyntax' to type 'Microsoft.CodeAnalysis.CSharp.Syntax.AttributeSyntax'.

   at StyleCop.Analyzers.ReadabilityRules.SA1133CodeFixProvider.<GetTransformedDocumentAsync>d__5.MoveNext()

(VS2015 update 1, StyleCop 1.0 RC1)

[sharwell]

Thanks for the report!

I am very much hoping this reproduces the problem in our unit tests. 😄

[NikolayIT]

This code is enough to reproduce the problem.

I've created a new branch in my fork in order to try fixing the issue. Here is the regression test: https://github.com/NikolayIT/StyleCopAnalyzers/commit/f25bde0e7eb2efa9e6a936e72dcbaf112606a968

The test is failing with

System.InvalidCastException

Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Syntax.AttributeListSyntax' to type 'Microsoft.CodeAnalysis.CSharp.Syntax.AttributeSyntax'.

   at StyleCop.Analyzers.ReadabilityRules.SA1133CodeFixProvider.<GetTransformedDocumentAsync>d__5.MoveNext() in C:\Dev\2015\StyleCopAnalyzers\StyleCop.Analyzers\StyleCop.Analyzers.CodeFixes\ReadabilityRules\SA1133CodeFixProvider.cs:line 54
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.CodeAnalysis.CodeActions.CodeAction.<GetChangedSolutionAsync>d__9.MoveNext()

[NikolayIT]

Well, that was very easy to fix. I am sending a pull request in a minute.

[sharwell]

@NikolayIT Make sure to send your pull request to the stabilization branch instead of the default master branch.

[NikolayIT]

@sharwell did it 😄