Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UsingCodeFixProvider does not handle aliases correctly #1770

Closed
sharwell opened this issue Nov 15, 2015 · 0 comments · Fixed by #1865
Closed

UsingCodeFixProvider does not handle aliases correctly #1770

sharwell opened this issue Nov 15, 2015 · 0 comments · Fixed by #1865
Assignees
@sharwell
Labels
bug fixed
Milestone
1.0.0 RC 1

Comments

@sharwell
Copy link
Member

Currently UsingCodeFixProvider can merge two using directives which do not use the same alias. The correct behavior is to allow merging a using directive which does not have an alias with any using directives which have the alias global::. Using directives with any other alias can only be merged with other using directives that have exactly the same alias.
@sharwell sharwell added the bug label Nov 15, 2015
@sharwell sharwell added this to the 1.0.0 RC 1 milestone Nov 29, 2015
@sharwell sharwell self-assigned this Nov 29, 2015
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Nov 29, 2015
@sharwell
Fix UsingCodeFixProvider handling of aliases
fb4a829 
This change can result in the output of this code fix containing duplicate
using directives, but this situation does not break the semantics of code
and only produces a build warning.

Fixes DotNetAnalyzers#1770
@sharwell sharwell mentioned this issue Nov 29, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
bug fixed
Projects
None yet
Milestone
1.0.0 RC 1
Development

Successfully merging a pull request may close this issue.

Fix UsingCodeFixProvider handling of aliases sharwell/StyleCopAnalyzers
1 participant
@sharwell