Update SA1008 to handle positional patterns inside property patterns

#3556
DotNetAnalyzers · Nov 18, 2022 · 79c6959 · 79c6959
1 parent 224763f
commit 79c6959
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 1 deletion.
diff --git a/StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp8/SpacingRules/SA1008CSharp8UnitTests.cs b/StyleCop.Analyzers/StyleCop.Analyzers.Test.CSharp8/SpacingRules/SA1008CSharp8UnitTests.cs
@@ -149,5 +149,50 @@ await VerifyCSharpFixAsync(
                 fixedCode,
                 CancellationToken.None).ConfigureAwait(false);
         }
+
+        [Fact]
+        [WorkItem(3556, "https://github.com/DotNetAnalyzers/StyleCopAnalyzers/issues/3556")]
+        public async Task TestInPositionalPatternAfterTagAsync()
+        {
+            var testCode = @"
+internal class TestClass
+    {
+        private void TestMethod(object obj)
+        {
+            _ = obj is ClassWithTuple { Tag:{|#0:(|} true, false) };
+        }
+
+        public class ClassWithTuple
+        {
+            public (bool Item1, bool Item2) Tag { get; set; }
+        }
+    }
+";
+            var fixedCode = @"
+internal class TestClass
+    {
+        private void TestMethod(object obj)
+        {
+            _ = obj is ClassWithTuple { Tag: (true, false) };
+        }
+
+        public class ClassWithTuple
+        {
+            public (bool Item1, bool Item2) Tag { get; set; }
+        }
+    }
+";
+            DiagnosticResult[] expectedResults =
+            {
+                Diagnostic(DescriptorPreceded).WithLocation(0),
+                Diagnostic(DescriptorNotFollowed).WithLocation(0),
+            };
+
+            await VerifyCSharpFixAsync(
+                testCode,
+                expectedResults,
+                fixedCode,
+                CancellationToken.None).ConfigureAwait(false);
+        }
     }
 }
diff --git a/...nalyzers/StyleCop.Analyzers/SpacingRules/SA1008OpeningParenthesisMustBeSpacedCorrectly.cs b/...nalyzers/StyleCop.Analyzers/SpacingRules/SA1008OpeningParenthesisMustBeSpacedCorrectly.cs
@@ -191,7 +191,8 @@ private static void HandleOpenParenToken(SyntaxTreeAnalysisContext context, Synt
                     || prevToken.IsKind(SyntaxKindEx.OrKeyword)
                     || prevToken.IsKind(SyntaxKindEx.AndKeyword)
                     || prevToken.IsKind(SyntaxKindEx.NotKeyword)
-                    || prevToken.IsKind(SyntaxKind.CommaToken);
+                    || prevToken.IsKind(SyntaxKind.CommaToken)
+                    || prevToken.IsKind(SyntaxKind.ColonToken);
                 break;
 
             case SyntaxKindEx.ParenthesizedPattern: