Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grafana dashboard improvements #49

Merged
merged 2 commits into from
May 8, 2024
Merged

Grafana dashboard improvements #49

merged 2 commits into from
May 8, 2024

Conversation

jplitza
Copy link
Contributor

@jplitza jplitza commented May 8, 2024

Current situation

The Grafana dashboard has a static datasource ID reference in one panel and changes its UID on every deployment.

Proposal

Use the datasource variable everywhere and set any static UID for the dashboard to enable persistent links.

jplitza added 2 commits May 8, 2024 11:05
Previously, every deployment caused a new UID to be generated,
invalidating all links to the dashboard.
@jplitza jplitza requested a review from a team as a code owner May 8, 2024 09:07
Copy link
Member

@raffis raffis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib 🎉

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8999221083

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 8611810683: 0.0%
Covered Lines: 175
Relevant Lines: 175

💛 - Coveralls

@raffis raffis merged commit 896b1a0 into DoodleScheduling:master May 8, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants